Skip to content

Make fields of execution mode optional with defaults #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 6, 2024
Merged

Make fields of execution mode optional with defaults #238

merged 8 commits into from
Jul 6, 2024

Conversation

plusminushalf
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3667233

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
permissionless (esm) 39.73 KB (0%)
permissionless (cjs) 118.67 KB (0%)
permissionless (minimal surface - tree-shaking) 10.09 KB (0%)

@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (b6bc8c2) to head (3667233).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   76.30%   84.13%   +7.82%     
==========================================
  Files         105      105              
  Lines       13297    13297              
  Branches      352      389      +37     
==========================================
+ Hits        10146    11187    +1041     
+ Misses       3144     2103    -1041     
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusminushalf plusminushalf force-pushed the 7579-execution-mode branch from ce5a46f to b08b394 Compare July 5, 2024 15:59
@plusminushalf plusminushalf merged commit 4717162 into main Jul 6, 2024
8 checks passed
@plusminushalf plusminushalf deleted the 7579-execution-mode branch July 6, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofgazso kristofgazso kristofgazso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plusminushalf @kristofgazso